Set Autocomplete Off on Login Form - Main #44926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests for logging driver validity
…tests for logging driver validity
…bigquery operator docstrings
geraj1010
requested review from
ryanahamilton,
ashb,
bbovenzi,
pierrejeambrun and
jscheffl
as code owners
boring-cyborg
bot
added
area:UI
geraj1010
changed the title
geraj1010
requested review from
bolkedebruin,
jedcunningham,
ephraimbuddy,
dstandish,
eladkal,
kaxil,
potiuk,
mobuchowski,
o-nikolas,
Fokko,
mik-laj,
hussein-awala,
josh-fell,
uranusjr,
jhtimmins and
XD-DENG
as code owners
|
Irrelevant commits are here, closing to resolve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #44019
Updated main Javascript to apply autocomplete="off" to both username and password inputs on login page. This will help prevent the browser from providing hints for the username (and password), as requested in the Issue.
Based on Flask-AppBuilder source code, i.e. https://github.com/dpgaspar/Flask-AppBuilder/tree/master/flask_appbuilder/templates/appbuilder/general/security (see login_db.html and login_ldap.html), this should work for both AUTH_DB (default) and AUTH_LDAP authentication, since they both apparently use the same HTML elements in the form.