Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AIP-44 from models/taskinstance #44510

Closed
wants to merge 9 commits into from
Closed

Remove AIP-44 from models/taskinstance #44510

wants to merge 9 commits into from

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Nov 30, 2024 •
edited
Loading

related to #44436

  • ./airflow/models/taskinstance.py: _merge_ti
  • ./airflow/models/taskinstance.py: _add_log
  • ./airflow/models/taskinstance.py: _update_ti_heartbeat
  • ./airflow/models/taskinstance.py: _xcom_pull
  • ./airflow/models/taskinstance.py: _get_template_context
  • ./airflow/models/taskinstance.py: _handle_failure
  • ./airflow/models/taskinstance.py: _record_task_map_for_downstreams
  • ./airflow/models/taskinstance.py: _update_rtif
  • ./airflow/models/taskinstance.py: _defer_task
  • ./airflow/models/taskinstance.py: _handle_reschedule
  • ./airflow/models/taskinstance.py: get_task_instance
  • ./airflow/models/taskinstance.py: _clear_xcom_data
  • ./airflow/models/taskinstance.py: _set_state
  • ./airflow/models/taskinstance.py: _get_dagrun
  • ./airflow/models/taskinstance.py: _check_and_change_state_before_execution
  • ./airflow/models/taskinstance.py: _register_asset_changes_int
  • ./airflow/models/taskinstance.py: save_to_db

@rawwar
Copy link
Collaborator Author

rawwar commented Nov 30, 2024

Once #44496 is merged, I need to pull changes and fix remaining failing tests

@rawwar rawwar mentioned this pull request Nov 30, 2024
Closed
90 tasks
@potiuk
Copy link
Member

potiuk commented Nov 30, 2024

Once #44496 is merged, I need to pull changes and fix remaining failing tests

Merged ! Go ahead!

@rawwar rawwar mentioned this pull request Dec 1, 2024
Merged
1 task
@rawwar rawwar marked this pull request as ready for review December 1, 2024 03:55
@rawwar rawwar requested a review from potiuk December 1, 2024 03:55
@rawwar rawwar mentioned this pull request Dec 1, 2024
Closed
3 tasks
@potiuk
Copy link
Member

potiuk commented Dec 1, 2024

Rebased and mered in #44540 .. Almost out-of the box after I rebased - and you are co-author @rawwar :)

@potiuk potiuk closed this Dec 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jscheffl jscheffl jscheffl left review comments

@eladkal eladkal eladkal approved these changes

@o-nikolas o-nikolas Awaiting requested review from o-nikolas o-nikolas is a code owner

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@bolkedebruin bolkedebruin Awaiting requested review from bolkedebruin bolkedebruin is a code owner

@XD-DENG XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

@potiuk potiuk Awaiting requested review from potiuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rawwar @potiuk @eladkal @jscheffl