Skip to content

Commit

Permalink
Fix missing input variables and output variable references in github …
Browse files Browse the repository at this point in the history
…workflows (#45384)
  • Loading branch information
gopidesupavan authored Jan 3, 2025
1 parent a2c5a48 commit 103b3ab
Show file tree
Hide file tree
Showing 8 changed files with 16 additions and 5 deletions.
4 changes: 0 additions & 4 deletions .github/actions/prepare_all_ci_images/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,6 @@ inputs:
platform:
description: 'Platform for the build - linux/amd64 or linux/arm64'
required: true
outputs:
host-python-version:
description: Python version used in host
value: ${{ steps.breeze.outputs.host-python-version }}
runs:
using: "composite"
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-image-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ jobs:
uses: ./.github/actions/breeze
with:
use-uv: ${{ inputs.use-uv }}
- name: "Restore ${{ inputs.image-type }} cache mount image ${{ inputs.platform }}:${{ inputs.python }}"
- name: "Restore ci-cache mount image ${{ inputs.platform }}:${{ env.PYTHON_MAJOR_MINOR_VERSION }}"
uses: apache/infrastructure-actions/stash/restore@c94b890bbedc2fc61466d28e6bd9966bc6c6643c
with:
key: "ci-cache-mount-save-v2-${{ inputs.platform }}-${{ env.PYTHON_MAJOR_MINOR_VERSION }}"
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -610,6 +610,7 @@ jobs:
python-versions: ${{ needs.build-info.outputs.python-versions }}
run-task-sdk-tests: ${{ needs.build-info.outputs.run-task-sdk-tests }}
use-uv: ${{ needs.build-info.outputs.use-uv }}
canary-run: ${{ needs.build-info.outputs.canary-run }}
if: >
( needs.build-info.outputs.run-task-sdk-tests == 'true' ||
needs.build-info.outputs.run-tests == 'true' &&
Expand Down Expand Up @@ -646,6 +647,7 @@ jobs:
disable-airflow-repo-cache: ${{ needs.build-info.outputs.disable-airflow-repo-cache }}
canary-run: ${{ needs.build-info.outputs.canary-run }}
use-uv: ${{ needs.build-info.outputs.use-uv }}
debug-resources: ${{ needs.build-info.outputs.debug-resources }}

notify-slack-failure:
name: "Notify Slack on Failure"
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/finalize-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,10 @@ on: # yamllint disable-line rule:truthy
description: "Whether to use uv to build the image (true/false)"
required: true
type: string
debug-resources:
description: "Whether to debug resources or not (true/false)"
required: true
type: string
jobs:
update-constraints:
runs-on: ${{ fromJSON(inputs.runs-on-as-json-public) }}
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/k8s-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ jobs:
uses: actions/checkout@v4
with:
persist-credentials: false
# env.PYTHON_MAJOR_MINOR_VERSION, env.KUBERNETES_VERSION are set in the previous
# step id: prepare-versions
- name: "Prepare breeze & PROD image: ${{ env.PYTHON_MAJOR_MINOR_VERSION }}"
uses: ./.github/actions/prepare_breeze_and_image
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/special-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,7 @@ jobs:
use-uv: ${{ inputs.use-uv }}
if: ${{ inputs.default-branch == 'main' }}

# matrix.test-group comes from run-unit-tests.yml
tests-system:
name: "System test: ${{ matrix.test-group }}"
uses: ./.github/workflows/run-unit-tests.yml
Expand Down
5 changes: 5 additions & 0 deletions .github/workflows/task-sdk-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,11 @@ on: # yamllint disable-line rule:truthy
description: "Whether to use uv to build the image (true/false)"
required: true
type: string
canary-run:
description: "Whether this is a canary run (true/false)"
required: true
type: string

jobs:
task-sdk-tests:
timeout-minutes: 80
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/test-provider-packages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -149,6 +149,7 @@ jobs:
--run-in-parallel
if: matrix.package-format == 'sdist'

# All matrix parameters are passed as JSON string in the input variable providers-compatibility-tests-matrix
providers-compatibility-tests-matrix:
timeout-minutes: 80
name: Compat ${{ matrix.airflow-version }}:P${{ matrix.python-version }} providers test
Expand Down

0 comments on commit 103b3ab

Please sign in to comment.