fix: validate limit/offset on webhook management routes with OffsetPaginationSchema - #1
Open
aojomo wants to merge 1 commit into
Open
fix: validate limit/offset on webhook management routes with OffsetPaginationSchema#1aojomo wants to merge 1 commit into
aojomo wants to merge 1 commit into
Conversation
…ginationSchema Add OffsetPaginationSchema to paginationSchema.ts and apply it to GET /deliveries and GET /dlq webhook routes. Non-numeric, negative, zero, and excessively large limit/offset values now return a clear 400 error instead of silently producing empty/wrong-sized pages. Closes Fluxora-Org#847.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add offset-based pagination validation to webhook management routes (GET /deliveries and GET /dlq) using a new OffsetPaginationSchema in the shared pagination validation module. Non-numeric, negative, zero, and excessively large limit/offset values now return a clear 400 INVALID_PAGINATION error instead of silently producing empty or wrong-sized pages.
Fixes Fluxora-Org#847
Changes
src/validation/paginationSchema.ts
src/routes/webhooks.ts
tests/webhooks-pagination.test.ts (new)
21 tests covering:
Acceptance Criteria