Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Trainer #38

Merged
merged 6 commits into from
Dec 2, 2018
Merged

implement Trainer #38

merged 6 commits into from
Dec 2, 2018

Conversation

aobo-y
Copy link
Owner

@aobo-y aobo-y commented Dec 2, 2018 •
edited
Loading

revise seq2seq to more appropriate class trainer

#1

as added in todo, seq2seq should be a model including both encoder & decoder

@aobo-y aobo-y changed the title Aobo pytorch implement Trainer Dec 2, 2018
@aobo-y aobo-y merged commit da1c171 into master Dec 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyu-du wyu-du wyu-du approved these changes

@jiahao42 jiahao42 Awaiting requested review from jiahao42

@quq99 quq99 Awaiting requested review from quq99

@ShiminLei ShiminLei Awaiting requested review from ShiminLei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aobo-y @wyu-du