chore: pin nightly version to avoid flaky build errors

[cpubot]

It seems the latest version of nightly broke miri. Pinning our nightly version for the miri suite to a known working version to avoid inconsistent builds.

[steviez]

I'm not positive that it matters, but should we choose a nightly build that aligns with MSRV ?

wincode/Cargo.toml

Line 21 in 0daa955

rust-version = "1.84.1"

wincode/rust-toolchain.toml

Lines 1 to 2 in 0daa955

	[toolchain]
	channel = "1.84.1"

For Agave, we have been following the convention of using the final corresponding (1.84 in this case) nightly build

[kskalski]

Using latest nightly is a double-edged sword - we get earlier validation for newest toolchain, so we can fix issues as they arise, but we also get upstream breakages like recent, since it's ultimately most-unstable toolchain you can get. It's even more painful when it happens for unrelated PRs.

Thus I agree - using nightly aligned with target toolchain is better. I wonder though how should be relate workspace's toolchain to MSRV, does it make sense to use different versions for them (e.g. #181)

[steviez]

so we can fix issues as they arise, but we also get upstream breakages like recent, since it's ultimately most-unstable toolchain you can get. It's even more painful when it happens for unrelated PRs.

Yeah, I think this statement is captures the key sentiment for pinning. Pinning gives us stability and lets us choose when we want to deal with breakages. On the other hand, using nightly could mean unrelated failures in critical times (ie if we ever have an urgent patch).

So, I think pinning is the correct move and the only question in my mind is whether we should pin nightly to match MSRV. I'm leaning towards aligning them

[cpubot]

Ok -- pinned to nightly as of the date of the 1.84.1 release