Skip to content

feat: Add initial cargo-deny configuration for advisories#123

Merged
nbelenkov merged 7 commits intoanza-xyz:masterfrom
tanmay4l:ci
Mar 3, 2026
Merged

feat: Add initial cargo-deny configuration for advisories#123
nbelenkov merged 7 commits intoanza-xyz:masterfrom
tanmay4l:ci

Conversation

@tanmay4l
Copy link
Copy Markdown
Contributor

@tanmay4l tanmay4l commented Jan 31, 2026

fixes - #122

@cpubot cpubot requested a review from nbelenkov February 2, 2026 21:06
Comment thread .github/workflows/ci.yml Outdated
@nbelenkov
Copy link
Copy Markdown
Contributor

Thanks for contributing this, I want to look over the toml in more detail and see if the settings make sense for us

@tanmay4l tanmay4l requested a review from nbelenkov February 3, 2026 04:20
nbelenkov
nbelenkov previously approved these changes Feb 23, 2026
Copy link
Copy Markdown
Contributor

@nbelenkov nbelenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, compeltely slipped my mind. lgtm to merge

@tanmay4l
Copy link
Copy Markdown
Contributor Author

sorry, compeltely slipped my mind. lgtm to merge

Thanks! I fixed the failing cargo-deny check (0.14.25 -> 0.14.24). Can you re-approve + approve the pending workflow ?

@tanmay4l tanmay4l requested a review from nbelenkov February 23, 2026 07:54
@tanmay4l
Copy link
Copy Markdown
Contributor Author

sorry, compeltely slipped my mind. lgtm to merge

Thanks! I fixed the failing cargo-deny check (0.14.25 -> 0.14.24). Can you re-approve + approve the pending workflow ?

We're good now

Copy link
Copy Markdown
Contributor

@nbelenkov nbelenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nbelenkov nbelenkov merged commit 343c866 into anza-xyz:master Mar 3, 2026
4 checks passed
Comment thread deny.toml
[advisories]
version = 2
yanked = "warn"
ignore = ["RUSTSEC-2025-0141"]
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignored advisories should have a reason attached

Comment thread deny.toml
"BSD-2-Clause",
"BSD-3-Clause",
"ISC",
"Unicode-DFS-2016",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are unmatched license allowances

@tanmay4l tanmay4l deleted the ci branch March 6, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants