Strip the TransactionMessageWithDurableNonceLifetime type when prepending instructions to a TransactionMessage #193
+85
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding instructions to a TransactionMessage
🦋 Changeset detectedLatest commit: 08c0c77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonUnchanged files (127)
No change in files bundle size Final result: ✅ View report in BundleMon website ➡️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's possible to create a
CompilableTransactionMessagethat actually is not. Take a valid durable nonce transaction message, and prepend any instruction with no accounts. This will remain aCompilableTransactionMessage, since prepending doesn't change the type, but when you attempt to compile it it'll throw an error trying to read accounts from the first instruction, which it expects to be a durable nonce advance instruction but is not.See compile code:
kit/packages/transactions/src/compile-transaction.ts
Lines 42 to 52 in 0ffbfb6
Summary of Changes
While we could add error checking to that compile code, the root cause is that
prependTransactionMessageInstruction(s)should never return aTransactionMessageWithDurableNonceLifetime. This PR modifies the types so that theTransactionMessageWithDurableNonceLifetimeis stripped if present on the input type.This means that the returned transaction is no longer a
CompilableTransactionMessageif it was previously aTransactionMessageWithDurableNonceLifetime, and you'll correctly get a type error if you attempt to compile it.This does not fix the bad error message if you eg cast such an invalid message to
TransactionMessageWithDurableNonceLifetime, so we might still decide to add runtime checks and errors. But since we've generally preferred type errors when possible, I think this is the best fix for now.Addresses #187