Feature/bug fix and enhancements#2
Open
LING-lab72 wants to merge 4 commits into
Open
Conversation
Bug修复: - 修复AssignRequest空值验证缺失 (Bug anweat#4) - 修复resubmit()只重置被拒绝的任务 (Bug #6) - 修复hasPendingTask严格相等类型不匹配 (Bug #8) 功能增强: - 用户注册验证增强 - 权限管理页面 - 操作日志双标签页 - 合同取消功能
- 添加缺失的 OperationLog 相关文件 - 修复 RoleController 和 UserController 构造函数中 operationLogService 未初始化的问题 - 修复 ContractController.cancel() 返回类型不匹配问题
Bug修复: - Bug4: AssignRequest 增加服务层显式非空校验，防止空分配死锁 - Bug6: resubmit() 重置所有审批任务(含已DONE)，避免跳过审批人 - Bug8: hasPendingTask 使用 Number() 转换避免 number/string 比较恒false 功能优化: 1. 角色分配改为单选(radio)，备选员工列表过滤起草人 2. 附件上传限制为非DRAFT状态方可提交 3. 状态标签更新: 起草→待分配, 已分配→待会签 4. 合同访问权限: 普通用户仅见关联合同, 新增管理员合同查询页 5. 分配/定稿纳入待办, 待办按合同分组展示 6. 审批/签订按钮仅在用户有对应待办任务时显示 7. 侧边栏待办小红点(30秒轮询), 移除起草合同子菜单 8. 注册/创建用户密码最小长度6位校验 9. 权限管理页面增加增删改功能 10. 权限分配按模块分组+全选/取消全选 11. 操作日志新增系统操作日志选项卡(用户/角色/权限审计) 12. 合同取消流程: 后端cancel端点+前端取消按钮
1. 重建 V2 Flyway 迁移文件 (H2+MySQL): 创建 operation_log 表及索引 2. ContractService.detail() 增加权限校验: 起草人/被分配人/管理员方可访问 3. ContractController 附件端点 (上传/列表/下载/删除) 增加 requireContractAccess 校验 4. router.js /tasks 路由权限数组添加 contract:assign
Owner
|
已接受并吸收这个 PR 里值得保留的关键改动，不过没有直接合并原分支，因为它和当前 已吸收内容包括：
对应发布分支和 draft PR：#4 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.