Add BGP confederation field in BGPPolicy API #6905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongliangl
added
action/release-note
hongliangl
force-pushed
the
20241205-bgp-confederation
branch
from
a61659d to
dc54219
Compare
hongliangl
changed the title
antoninbas
reviewed
Jan 8, 2025
antoninbas
reviewed
Jan 8, 2025
hongliangl
force-pushed
the
20241205-bgp-confederation
branch
from
dc54219 to
cde61b3
Compare
hongliangl
changed the title
hongliangl
force-pushed
the
20241205-bgp-confederation
branch
from
cde61b3 to
a7bd0c2
Compare
antoninbas
reviewed
Jan 16, 2025
luolanzone
reviewed
Jan 17, 2025
Comment on lines
+71
to
+72
| minimum: 1 | ||
| maximum: 65535 |
There was a problem hiding this comment.
I saw there is a suggestion is to use private ASN 64512–65534 for peers. But I am not sure if it's mandatory or just a recommendation. Could you double check the range?
If it's mandatory, we may need to remind users in the guide later when the full feature is ready. Thanks.
There was a problem hiding this comment.
Is this one #6905 (comment)?
There was a problem hiding this comment.
I think private ASNs are typically used inside a confederation but I don't believe it's required. We can mention it in the documentation as you suggested.
hongliangl
force-pushed
the
20241205-bgp-confederation
branch
2 times, most recently
from
c0448d7 to
d553698
Compare
luolanzone
previously approved these changes
Jan 20, 2025
antoninbas
requested changes
Jan 21, 2025
Signed-off-by: Hongliang Liu <[email protected]>
hongliangl
force-pushed
the
20241205-bgp-confederation
branch
from
d553698 to
b24f25d
Compare
luolanzone
approved these changes
Jan 22, 2025
antoninbas
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #6567