Repository navigation
fix(cli): fall back to module version when ldflags is absent - #7
Merged
Merged
Conversation
go install github.com/antonysastre/sheets/cmd/she@latest bypasses our Makefile and produces a binary with version="dev", so users following the README's "From source" path see an uninformative version string. versionString now consults runtime/debug.ReadBuildInfo when the ldflags-injected value is the dev sentinel, returning the module version baked in by go install. Local make build is unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`go install github.com/antonysastre/sheets/cmd/she@latest` (the README's "From source" path) bypasses our Makefile, so the resulting binary reports `she dev` instead of a real version. `versionString` now falls back to `runtime/debug.ReadBuildInfo` when the ldflags-injected value is the `dev` sentinel, returning the module version baked in by `go install`.
Discovered while verifying README claims against actual behavior — every other documented behavior (sheet format rules, all CLI flags, curl-bash installer, goreleaser dry-run, GitHub Actions release workflow) checks out.
Test plan