Repository navigation
Markdown-flavored sheet format - #5
Merged
Merged
Conversation
Hard cutover from `command > description` / `//` to a grammar of blanks, `#` comments/descriptions, and capital-letter section headers.
Stop filtering empty lines so authored blank rows render as visible separators. Also trim a trailing newline to avoid a phantom blank.
Commands sit flush-left; descriptions align in one column based on the longest command in the sheet, computed once per file.
Renames the local accumulator in MaxCommandWidth to avoid shadowing Go 1.21's builtin max, and notes that alignment is rune-count-based. Adds a test for source padding combined with a width parameter.
antonysastre
force-pushed
the
worktree-markdown-format
branch
from
May 16, 2026 02:22
dcc5421 to
58a39fb
Compare
Prefixes `_, _ =` on every unchecked fmt.Fprint* call in commands.go, pager.go, and sync.go to match the existing convention (visible in sheet.List) and clear the errcheck lint failures blocking PR merges under the new branch ruleset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hard cutover of
she's sheet format fromcommand > description///to a small markdown-flavored grammar:#(free-standing; rendered dim italic).#is the command; anything after is the description (rendered green +·+ italic). The first#always wins, so URL fragments end the command.The pager precomputes the longest command in the sheet via a new
MaxCommandWidthhelper and column-aligns all descriptions; commands sit flush-left (no leading indent). The bespokeValidateFormatwarning block is gone — every line is structurally valid under the new grammar.Three commits, each compiling and passing tests on its own:
feat(sheet): switch to markdown-flavored sheet formatfeat(sheet): honor blank source lines in Viewfeat(sheet): align descriptions and drop command indentExisting user sheets in the old format render as plain command lines until ported by hand (no in-tree migration; the user's own sheets were ported separately).