Repository navigation
ci: open release PR by open-state lookup, not branch name - #41
Merged
Merged
Conversation
gh pr view/merge by the release/next branch name can resolve to a stale MERGED PR from a prior release (the head branch is reused each cycle). The release job then took the edit-existing-PR path and never opened a new PR, yet exited 0 - so 'Open release PR' reported success while no PR was created and the version bump stranded on release/next (master stayed on the previous version, no tag). Resolve via 'gh pr list --head release/next --base master --state open' and operate on the explicit PR number for create/edit/merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Automated Releasereported "Open release PR" success but opened no PR; the v1.17.0 bump stranded onrelease/next(master stayed v1.16.0, no tag) until the PR was opened manually.Root cause
gh pr view release/next/gh pr merge release/nextresolve by branch name, which can match a stale MERGED PR (therelease/nexthead is reused every release). The script then took the edit-existing-PR path and skippedgh pr create, while still exiting 0.Fix
Resolve the release PR via
gh pr list --head release/next --base master --state openand act on the explicit PR number for create/edit/merge. No PR open -> create; open PR -> refresh title; then--auto --squash.ci:prefix so this change does not itself cut a release.