Implemented following two array helper functions with corresponding unit tests #133
Conversation
tests: MapFilter: Return a array of `V` by applying transform to all elements of array 'U' and filtering out failure ones MapM: Return a Result with an array of `V`s if all Results of applying `transform` are `Success`es or return the error of the first `Failure`
| } | ||
| } | ||
| return Result(vs) | ||
| } |
There was a problem hiding this comment.
I think both of these would be more idiomatic if expressed as extension methods on CollectionType. Not only more idiomatic, but they’d also be available on collections other than Array.
|
Thanks for the pull request! 🙇 This functionality is quite useful. I’ve left a few notes above, but you might not want to address any/all of them straight away since there’s some question about where this should end up living. We’ve typically shied away from including extensions on other types in Result, but we’ve been discussing providing a home for them, possibly in a separate framework. @antitypical/result, what do you think? Is this a good motivator for a |
|
I agree, this is useful but it seems out of the scope of |
MapFilter: Return a array of
Vby applying transform to all elementsof array 'U' and filtering out failure ones
MapM: Return a Result with an array of
Vs if all Results of applyingtransformareSuccesses or return the error of the firstFailure