feat: stream markdown #2230
Open
feat: stream markdown #2230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er for markdown rendering
…typewriter effect
…ing in StreamWriter
…r management during writes
… control and writer flushing
- Added `OutputPrinter` trait for thread-safe writing to stdout and stderr. - Implemented `OutputPrinterInfra` in various services to utilize the new output printer. - Refactored `ForgeCommandExecutorService` to use `OutputPrinter` for command output. - Updated `SpinnerManager` to support output printing through the new trait. - Removed acknowledgment mechanism from `ChatResponse` to simplify tool call handling. - Enhanced `StreamWriter` to work with `OutputPrinter` for better output management. - Updated dependencies in `Cargo.lock` to include `forge_domain`.
laststylebender14
changed the title
github-actions
bot
added
the
type: feature
Co-Authored-By: ForgeCode <[email protected]>
…ove spinner management
…ush calls and simplifying text checks
… for graceful completion
…mplementation for DirectWriter
…and direct output
… update references
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
|
||
| /// Start the spinner with a message. | ||
| pub fn start(&self, message: Option<&str>) -> Result<()> { | ||
| self.0.lock().unwrap().start(message) |
Contributor
There was a problem hiding this comment.
Panic Risk: Unwrapping mutex lock will panic if the mutex is poisoned (e.g., if a thread panicked while holding the lock). This will crash the application in production.
// Fix: Handle the poison error gracefully
pub fn start(&self, message: Option<&str>) -> Result<()> {
self.0.lock()
.map_err(|e| anyhow::anyhow!("Spinner mutex poisoned: {}", e))?
.start(message)
}
Suggested change
| self.0.lock().unwrap().start(message) | |
| self.0.lock() | |
| .map_err(|e| anyhow::anyhow!("Spinner mutex poisoned: {}", e))? | |
| .start(message) |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
| } | ||
| })); | ||
| }); | ||
| *self.tracker.lock().unwrap() = Some(handle); |
Contributor
There was a problem hiding this comment.
Panic Risk: Unwrapping mutex lock will panic if the mutex is poisoned. Since this is in the hot path of spinner operations, a poisoned mutex will crash the application.
// Fix: Handle the poison error gracefully
let mut tracker_guard = self.tracker.lock()
.map_err(|e| anyhow::anyhow!("Tracker mutex poisoned: {}", e))?;
*tracker_guard = Some(handle);
Suggested change
| *self.tracker.lock().unwrap() = Some(handle); | |
| let mut tracker_guard = self.tracker.lock() | |
| .map_err(|e| anyhow::anyhow!("Tracker mutex poisoned: {}", e))?; | |
| *tracker_guard = Some(handle); | |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
tusharmath
reviewed
Jan 9, 2026
| forge_select = { path = "crates/forge_select" } | ||
| forge_test_kit = { path = "crates/forge_test_kit" } | ||
|
|
||
| forge_markdown_stream = { git = "https://github.com/laststylebender14/forge_markdown_stream", branch = "master" } |
Collaborator
There was a problem hiding this comment.
Move the project into our repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.