feat(patch): add fuzzy search support with gRPC integration and range conversion #2228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type: feature
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Fixes a potential panic in from_search_match when SearchMatch references a line number beyond the end of the source text. When both start_idx and end_idx equal lines.len(), accessing lines[start_idx] would cause a panic. Added bounds check to return 0 length for out of bounds matches. Co-Authored-By: ForgeCode <[email protected]>
Add bounds check in the multi-line match case of from_search_match to prevent array out of bounds panic when start_idx >= lines.len() or end_idx > lines.len(). This complements the earlier fix for single-line matches. Co-Authored-By: ForgeCode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.