feat(spinner): display token usage and cost information during execution

[laststylebender14]

fixes: #1789

[graphite-app]

Logic bug in pattern matching. When accumulated is None and last_request is Some, the pattern (None, Some(acc)) binds acc to last_request, not accumulated. This contradicts the comment on line 2627 which states "Use accumulated for cost and cache rate". In this case, cost and cache_hit_rate will be calculated from last_request instead of accumulated.

The second match arm should only handle (Some(acc), None) to use accumulated data. The (None, Some(last)) case should be handled separately:

(Some(acc), None) => [
    acc.cost.map(|c| format!("${:.3}", c)),
    Some(format!("{}/{}", *acc.prompt_tokens, *acc.completion_tokens)),
    acc.cache_hit_rate().map(|p| format!("{:.2}%", p)),
],
(None, Some(last)) => [
    None, // No accumulated cost
    Some(format!("{}/{}", *last.prompt_tokens, *last.completion_tokens)),
    None, // No accumulated cache rate
],

Suggested change

	(Some(acc), None) | (None, Some(acc)) => [
	acc.cost.map(|c| format!("${:.3}", c)),
	Some(format!("{}/{}", *acc.prompt_tokens, *acc.completion_tokens)),
	acc.cache_hit_rate().map(|p| format!("{:.2}%", p)),
	],
	(Some(acc), None) => [
	acc.cost.map(|c| format!("${:.3}", c)),
	Some(format!("{}/{}", *acc.prompt_tokens, *acc.completion_tokens)),
	acc.cache_hit_rate().map(|p| format!("{:.2}%", p)),
	],
	(None, Some(last)) => [
	None, // No accumulated cost
	Some(format!("{}/{}", *last.prompt_tokens, *last.completion_tokens)),
	None, // No accumulated cache rate
	],

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Inconsistency between current_message and the displayed message. Line 165 stores the full message including the word prefix (format!("{} {}", word, message)), but line 166 only displays the message parameter without the word prefix. This creates a mismatch between the internal state and what's displayed.

The displayed message should match the stored state:

pub fn set_message(&mut self, message: &str) -> Result<()> {
    if let Some(pb) = &self.progress_bar {
        let idx = *self
            .word_index
            .get_or_insert_with(|| rand::rng().random_range(0..THINKING_WORDS.len()));
        let word = THINKING_WORDS[idx].to_string();
        let full_message = format!("{} {}", word, message);
        self.current_message = Some(full_message.clone());
        pb.set_message(full_message.green().bold().to_string());
    }
    Ok(())
}

Suggested change

	pub fn set_message(&mut self, message: &str) -> Result<()> {
	if let Some(pb) = &self.progress_bar {
	let idx = *self
	.word_index
	.get_or_insert_with(|| rand::rng().random_range(0..THINKING_WORDS.len()));
	let word = THINKING_WORDS[idx].to_string();
	self.current_message = Some(format!("{} {}", word, message));
	pb.set_message(message.green().bold().to_string());
	}
	Ok(())
	}
	pub fn set_message(&mut self, message: &str) -> Result<()> {
	if let Some(pb) = &self.progress_bar {
	let idx = *self
	.word_index
	.get_or_insert_with(|| rand::rng().random_range(0..THINKING_WORDS.len()));
	let word = THINKING_WORDS[idx].to_string();
	let full_message = format!("{} {}", word, message);
	self.current_message = Some(full_message.clone());
	pb.set_message(full_message.green().bold().to_string());
	}
	Ok(())
	}

Spotted by Graphite Agent



Is this helpful? React 👍 or 👎 to let us know.

[github-actions]

Action required: PR inactive for 5 days.
Status update or closure in 10 days.