feat(credential): make credentials loading resilient #2073
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type: fix
laststylebender14
changed the title
github-actions
bot
added
the
type: feature
|
Action required: PR inactive for 5 days. |
github-actions
bot
added
the
state: inactive
laststylebender14
removed
state: inactive
laststylebender14
added a commit
that referenced
this pull request
Dec 16, 2025
Apply the same resilience pattern from PR #2073 (.credentials.json) to .config.json: - Try normal JSON parsing first - Fall back to JSON repair via forge_json_repair for syntactically broken JSON - Return default config if all else fails This ensures Forge can boot up even with a partially corrupt .config.json file. Co-Authored-By: ForgeCode <[email protected]>
laststylebender14
force-pushed
the
chore/make-credential-json-loading-resilient
branch
2 times, most recently
from
3ed5c2b to
cc108e2
Compare
tusharmath
reviewed
Dec 17, 2025
laststylebender14
force-pushed
the
chore/make-credential-json-loading-resilient
branch
from
0360154 to
6811100
Compare
github-actions
bot
added
the
state: inactive
github-actions
bot
removed
the
state: inactive
|
Action required: PR inactive for 5 days. |
github-actions
bot
added
the
state: inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.