fix(skill-creator): rename expectations to assertions in evals.json schema - #1679
Open
saeedseyfi wants to merge 1 commit into
Open
fix(skill-creator): rename expectations to assertions in evals.json schema#1679saeedseyfi wants to merge 1 commit into
saeedseyfi wants to merge 1 commit into
Conversation
…chema The evals.json schema in schemas.md called the field "expectations", but SKILL.md uses "assertions" in five places. This mismatch caused inconsistent hand-written eval files. The grading.json section keeps "expectations" unchanged — the aggregation script and viewer depend on that exact field name. Closes anthropics#1443
saeedseyfi
marked this pull request as ready for review
August 27, 2026 08:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expectationstoassertionsin theevals.jsonschema section ofreferences/schemas.md(field name + bullet), matching the five references inSKILL.mdgrading.jsonsection unchanged —expectationsis correct there and is read byaggregate_benchmark.pyandviewer.htmlFixes #587
Context
SKILL.mdusesassertionsconsistently (lines 145, 161, 195, 201, 205), butschemas.mdcalled the sameevals.jsonfieldexpectations. Nothing readsevals.jsonprogrammatically, so this never caused a crash — just inconsistent hand-written eval files when a reader followed one doc versus the other.Test plan
grading.jsonexpectations field is unchanged (the aggregation script and viewer depend on it)SKILL.mdreferences to "assertions" now match the schema doc