Drop six unused locals from the description optimizer report - #1675
Open
oliverames wants to merge 1 commit into
Open
Drop six unused locals from the description optimizer report#1675oliverames wants to merge 1 commit into
oliverames wants to merge 1 commit into
Conversation
generate_html still fetches holdout and best_train_score, and the history loop fetched train_passed, train_total, test_passed, and test_total even though row scores have been computed fresh by aggregate_runs since that helper landed. None of the six names is read anywhere. Removing them keeps the report honest about where its numbers come from.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_htmlin the skill-creator optimizer report still fetchesholdoutandbest_train_score, and the history loop fetchestrain_passed,train_total,test_passed, andtest_totalon every iteration. None of the six names is read anywhere. The row scores come fromaggregate_runs, which recomputes correct and total counts directly from the per-query results, so the four loop locals look like leftovers from before that helper landed.Removing them changes no output. It just makes the script honest about where its numbers come from, which matters in a report people read while deciding whether to trust an optimized description.
A pyflakes pass over the bundled scripts is what surfaced these, if you would like me to send through anything else it finds.