-
Notifications
You must be signed in to change notification settings - Fork 22
Add readme file for nuget package #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Add readme file for nuget package #57
Conversation
* Add some more tests for Anthropic{Beta}ClientExtensions
* Fix csharpier
|
|
||
| ## Installation | ||
|
|
||
| `dotnet add package Anthropic.Foundry` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `dotnet add package Anthropic.Foundry` | |
| ```sh | |
| dotnet add package Anthropic.Foundry | |
| ``` |
| ## Contents | ||
|
|
||
| - Library source: src/Anthropic.Foundry | ||
| - Unit/integration tests: tests (if present) | ||
| - Samples and usage examples: examples (if present) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem useful and I would delete (I also don't understand the "if present" thing)
| .Where(message => message.Value is TextBlock) | ||
| .Select(message => message.Value as TextBlock) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious if it's possible to merge this by doing some sort of "select not null" type thing on the as TextBlock?
| @@ -0,0 +1,46 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not make all these the same property group?
| <PackageReference Include="System.Text.Json" Version="10.0.0"/> | ||
| <PackageReference Include="Microsoft.Extensions.AI.Abstractions" Version="10.0.0"/> | ||
| <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0" PrivateAssets="All"/> | ||
| <None Include="..\logo.png" Pack="true" PackagePath="\" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logo seems to be in Directory.Build.props already
| <None Include="..\..\README.md" Pack="true" PackagePath="\" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="System.Text.Json" Version="10.0.0" /> | ||
| <PackageReference Include="Microsoft.Extensions.AI.Abstractions" Version="10.0.0" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can merge these item groups?
| <PackageProjectUrl>https://github.com/anthropics/anthropic-sdk-csharp</PackageProjectUrl> | ||
| <RepositoryUrl>https://github.com/anthropics/anthropic-sdk-csharp</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| <LangVersion>Latest</LangVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete this in favor of <LangVersion>12</LangVersion> above
|
|
||
| <AllowedOutputExtensionsInPackageBuildOutputFolder> | ||
| $(AllowedOutputExtensionsInPackageBuildOutputFolder);.pdb</AllowedOutputExtensionsInPackageBuildOutputFolder> | ||
| <SupportedFrameworks>net8.0;net9.0;netstandard2.0</SupportedFrameworks> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have both SupportedFrameworks and TargetFrameworks above. Why?
| <Copyright>Copyright 2025 Anthropic</Copyright> | ||
| <PackageProjectUrl>https://docs.anthropic.com/claude/reference/</PackageProjectUrl> | ||
| <RepositoryUrl>https://www.github.com/anthropics/anthropic-sdk-csharp</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have RepositoryType duplicated below. Can you please double-check that we have no duplication and no redundancies here?
| @@ -1,11 +1,10 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
| <PropertyGroup> | |||
| <TargetFrameworks>net8.0;net9.0;netstandard2.0</TargetFrameworks> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is redundant with Directory.Build.props
Can you carefully check that there is no duplication between the csproj and the shared props?
| Anthropic Foundry SDK for .NET — A .NET client library for Anthropic Foundry, providing typed models, API bindings, and authentication helpers to integrate Anthropic services into .NET applications. | ||
| Examples: | ||
| - Quickstart: | ||
| 1. Create a client (API key or Azure credential). | ||
| 2. Call the client to request a completion or classification and handle the response. | ||
| - Streaming: | ||
| Use the streaming helpers to receive partial tokens as they are produced for responsive UIs. | ||
| - Authentication: | ||
| Support for environment API key (`ANTHROPIC_FOUNDRY_API_KEY` environment variable) and Azure Identity (DefaultAzureCredential). | ||
| - Samples: | ||
| See the repository's examples/ directory for complete examples (console app and streaming examples). | ||
| - Install: | ||
| `dotnet add package Anthropic.Foundry` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this support Markdown? How does the indentation work, does it need to be all the way to the left or is indentation under the <Description> tag fine?
a6ccfa7 to
007b0c0
Compare
Also add short description for nuget package