-
Notifications
You must be signed in to change notification settings - Fork 22
Update Anthropic Foundry Identity Token Credential #55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: next
Are you sure you want to change the base?
Update Anthropic Foundry Identity Token Credential #55
Conversation
sd-st
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! Just had a few minor comments
src/Anthropic.Foundry/AnthropicFoundryIdentityTokenCredentials.cs
Outdated
Show resolved
Hide resolved
src/Anthropic.Foundry/AnthropicFoundryIdentityTokenCredentials.cs
Outdated
Show resolved
Hide resolved
|
Would you be able to retarget this to the |
Sure, done! |
|
@rogerbarreto There's a lint failure 😞 |
|
@sd-st, merged |
a6ccfa7 to
007b0c0
Compare
|
Hey @rogerbarreto do you mind rebasing this? Looks like something got messed up and the diff is huge now. |
* "Claude PR Assistant workflow" * "Claude Code Review workflow"
79f244c to
2653be1
Compare
|
@sd-st, Done (from what I could remember), I also noticed with the latest Note The process of the automation / codegen you are using in the repo is also messing up with all the PR's and possibly touching/altering / force-pushing into PRs git history is the reason. |
|
Looks like there's a lint failure from the formatting |
d3bef74 to
9ad3dc0
Compare

Problem Statement
Problem Statement
The current implementation accepts only a static
AccessToken, which is suitable for scenarios like anApiKeythat remains valid indefinitely during the client's lifetime. However, this approach fails for otherAccessTokentypes that expire and require periodic renewal.To address this, the change delegates token management to the specialized
TokenCredentialimplementation.