Skip to content

Conversation

@rogerbarreto
Copy link
Contributor

@rogerbarreto rogerbarreto commented Dec 2, 2025

Problem Statement

Problem Statement

The current implementation accepts only a static AccessToken, which is suitable for scenarios like an ApiKey that remains valid indefinitely during the client's lifetime. However, this approach fails for other AccessToken types that expire and require periodic renewal.

To address this, the change delegates token management to the specialized TokenCredential implementation.

@rogerbarreto rogerbarreto requested a review from a team as a code owner December 2, 2025 14:01
Copy link
Collaborator

@sd-st sd-st left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Just had a few minor comments

@sd-st
Copy link
Collaborator

sd-st commented Dec 5, 2025

Would you be able to retarget this to the next branch?

@rogerbarreto rogerbarreto changed the base branch from main to next December 6, 2025 12:57
@rogerbarreto
Copy link
Contributor Author

Would you be able to retarget this to the next branch?

Sure, done!

@sd-st
Copy link
Collaborator

sd-st commented Dec 11, 2025

@rogerbarreto There's a lint failure 😞

@rogerbarreto
Copy link
Contributor Author

Something is off.

This is what I get from my current branch, up-to-date, lint and format don't require any change.

image

@rogerbarreto
Copy link
Contributor Author

@sd-st, merged next into the PR to see if a new pipeline run can work.

@stainless-app stainless-app bot force-pushed the next branch 2 times, most recently from a6ccfa7 to 007b0c0 Compare December 18, 2025 22:39
@sd-st
Copy link
Collaborator

sd-st commented Dec 19, 2025

Hey @rogerbarreto do you mind rebasing this? Looks like something got messed up and the diff is huge now.

dtmeadows and others added 2 commits December 19, 2025 15:46
* "Claude PR Assistant workflow"

* "Claude Code Review workflow"
@rogerbarreto rogerbarreto force-pushed the anthropic-foundry-tokencredential-impl branch from 79f244c to 2653be1 Compare December 23, 2025 00:21
@rogerbarreto
Copy link
Contributor Author

rogerbarreto commented Dec 23, 2025

@sd-st, Done (from what I could remember), I also noticed with the latest next branch, a bunch of Unit Tests are failing... unrelated to this PR.

Note

The process of the automation / codegen you are using in the repo is also messing up with all the PR's and possibly touching/altering / force-pushing into PRs git history is the reason.
Ideally for a healthy contribution environment this should be avoided.

@sd-st
Copy link
Collaborator

sd-st commented Jan 6, 2026

Looks like there's a lint failure from the formatting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants