Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Update docstring and App.save_as() #1001

Merged
merged 5 commits into from
Dec 13, 2024
Merged

FEAT: Update docstring and App.save_as() #1001

merged 5 commits into from
Dec 13, 2024

Conversation

dipinknair
Copy link
Collaborator

  • Update save_as function with respect different version
  • Update doc strings for App

@dipinknair dipinknair marked this pull request as ready for review December 9, 2024 21:56
@dipinknair dipinknair requested a review from a team as a code owner December 9, 2024 21:56
@dipinknair dipinknair requested a review from koubaa December 9, 2024 21:56
@github-actions github-actions bot added the maintenance Package and maintenance related label Dec 9, 2024
@dipinknair dipinknair requested a review from klmcadams December 9, 2024 21:57
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.65%. Comparing base (8517e6c) to head (391d2fe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1001      +/-   ##
==========================================
- Coverage   87.41%   83.65%   -3.77%     
==========================================
  Files          35       35              
  Lines        2257     2251       -6     
==========================================
- Hits         1973     1883      -90     
- Misses        284      368      +84     

@dipinknair dipinknair requested a review from sbradrick December 9, 2024 22:26
@dipinknair dipinknair enabled auto-merge (squash) December 13, 2024 23:09
@dipinknair dipinknair merged commit c416441 into main Dec 13, 2024
48 of 49 checks passed
@dipinknair dipinknair deleted the maint/save_as branch December 13, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants