Skip to content

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Oct 15, 2025

Description

As the title.

Issue linked

Close #4238

Checklist

@germa89 germa89 requested a review from a team as a code owner October 15, 2025 10:02
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new GitHub Actions workflow job to audit the security of GitHub Actions usage in the repository. This addresses security concerns by implementing automated checks on action usage as part of the CI pipeline.

  • Adds actions-security job to CI workflow
  • Configures security auditing with high-level checks and Ansys actions trust
  • Enables automated summary generation for security audit results

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@germa89 germa89 requested a review from a team October 15, 2025 10:03
@germa89 germa89 enabled auto-merge (squash) October 15, 2025 10:03
@github-actions github-actions bot added CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc) labels Oct 15, 2025
@codecov
Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.27%. Comparing base (98a8f85) to head (eacca68).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4260      +/-   ##
==========================================
- Coverage   91.33%   91.27%   -0.07%     
==========================================
  Files         193      193              
  Lines       15720    15720              
==========================================
- Hits        14358    14348      -10     
- Misses       1362     1372      +10     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@RobPasMue
Copy link
Member

RobPasMue commented Oct 15, 2025

Looks like you have some fixes to perform right @germa89 ?

Run python ${GITHUB_ACTION_PATH}/../python-utils/zizmor-summary.py
=========                                         ================    
File name                                         Number of issues    
=========                                         ================    
./.github/actions/build-matrix/action.yml         5                   
./.github/actions/pytest-summary/action.yml       3                   
./.github/actions/test-julia/action.yml           1                   
./.github/actions/test-windows/action.yml         4                   
./.github/workflows/approver.yml                  18                  
./.github/workflows/cache_cleaner.yml             8                   
./.github/workflows/ci.yml                        19                  
./.github/workflows/codeql-analysis.yml           5                   
./.github/workflows/doc-build.yml                 23                  
./.github/workflows/docker_clean_untagged.yml     2                   
./.github/workflows/label.yml                     14                  
./.github/workflows/linkchecker.yml               4                   
./.github/workflows/migrator.yml                  14                  
./.github/workflows/pr-docs-cleaner.yml           2                   
./.github/workflows/test-local.yml                26                  
./.github/workflows/test-remote.yml               33                  
=========                                         ================    
Total                                             181                 
=========                                         ================    

@germa89
Copy link
Collaborator Author

germa89 commented Oct 16, 2025

@RobPasMue I knowww 😭😭😭

@jorgepiloto
Copy link
Member

jorgepiloto commented Oct 16, 2025

@germa89, use https://github.com/suzuki-shunsuke/pinact to automatically pin the latest hash for the actions you use. It will save you some time when addressing previous warnings.

GitHub
pinact is a CLI to edit GitHub Workflow and Composite action files and pin versions of Actions and Reusable Workflows. pinact can also update their versions and verify version annotations. - suzuki...

@germa89
Copy link
Collaborator Author

germa89 commented Oct 16, 2025

thank you a lot @jorgepiloto !! 😄

Unify workflows to use top-level `permissions: {}` and grant minimal, explicit
job-level permissions where needed across GitHub Actions (ci, doc-build,
test-local, test-remote, approver, cache_cleaner, codeql-analysis, docker_clean_untagged,
label, linkchecker, migrator, pr-docs-cleaner).

Also include small behavioural fixes:
- Pass BUILDER via env in doc-build and use it when invoking Make.
- Introduce PYTHON_ACTIVATE env usage in CI steps that activate venvs.
- Use LATEST_VERSION env in test-local and annotate container image as unpinned.
- Minor reorganization of permissions/read/write scopes per job.
@germa89
Copy link
Collaborator Author

germa89 commented Oct 20, 2025

@RobPasMue @jorgepiloto @moe-ad ... it took aaaaagess....

Copy link
Contributor

@moe-ad moe-ad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀 🚀

@germa89
Copy link
Collaborator Author

germa89 commented Oct 20, 2025

I think the permission changes are going to bite me in the future...

@pyansys-ci-bot LGTM.

Copy link
Contributor

@pyansys-ci-bot pyansys-ci-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89 germa89 merged commit 709e72b into main Oct 20, 2025
48 checks passed
@germa89 germa89 deleted the ci/adding-check-actions-security-job branch October 20, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD Related with CICD, Github Actions, etc maintenance General maintenance of the repo (libraries, cicd, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MAINTENANCE] Missing or outdated ansys/actions/check-actions-security action in ansys/pymapdl

5 participants