test: Fix tests which are failing in the latest nightly [skip tests] #4565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkundu1
requested review from
hpohekar,
mayankansys,
prmukherj and
seanpearsonuk
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR addresses test failures in the latest nightly build by adjusting test expectations for version-specific behavior changes in Fluent 26.1. The changes add version checks to skip or modify assertions that no longer apply to the newer version.
- Added version guard for exception behavior test that no longer throws in v26.1 (Fluent bug 1354052)
- Changed strict equality check to superset check for command names in v25.1+
- Added version guard for list command argument assertion that changed in v26.1
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/test_session.py | Added version check to skip exception test for v26.1+ due to known Fluent bug |
| tests/test_flobject.py | Modified command names assertion to use superset check and added version guard for list command behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
mkundu1
commented
Oct 21, 2025
tests/test_flobject.py
Outdated
| "delete", | ||
| "rename", | ||
| "list", | ||
| "list_properties", |
There was a problem hiding this comment.
In 26.1, above 2 commands are replaced with base class methods
mkundu1
changed the title
mkundu1
force-pushed
the
fix/test_default_argument_names_for_commands
branch
from
71ae17e to
cbecf82
Compare
mkundu1
force-pushed
the
fix/test_default_argument_names_for_commands
branch
from
4b9c157 to
6b7b609
Compare
mkundu1
force-pushed
the
fix/test_default_argument_names_for_commands
branch
from
e7fbc31 to
7f60a5c
Compare
seanpearsonuk
approved these changes
Oct 22, 2025
prmukherj
approved these changes
Oct 22, 2025
|
@mkundu1, This is working fine with me with this week's image: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not able to reproduce tests/test_field_data.py::test_field_data_errors's failure (yet).