Move errors to warnings when the code passes through (#429)

When the code passes the error and has work arounds or alternative
routes, lower the level so it's recorded in the logger debugging, not
error / warning.
This ensures that tests pass, since currently some fail due to spurious
"error" messages

Author: margalva

src/ansys/dynamicreporting/core/utils/report_objects.py

@@ -177,7 +177,7 @@ def map_ensight_plot_to_table_dictionary(p):
         try:
             a[a == ensight.Undefined] = numpy.nan
         except Exception as e:
-            logger.error(f"Error: {str(e)}.\n")
+            logger.debug(f"Warning: {str(e)}.\n")
             pass
         max_columns = max(a.shape[1], max_columns)
         d = dict(array=a, yname=q.LEGENDTITLE, xname=x_axis_title)
@@ -405,7 +405,7 @@ def get_params(self):
         try:
             return json.loads(self.params)
         except Exception as e:
-            logger.error(f"Error: {str(e)}.\n")
+            logger.debug(f"Warning on get_params: {str(e)}.\n")
             return {}
 
     def set_params(self, d: dict = None):
@@ -1333,7 +1333,7 @@ def set_payload_image(self, img):
             try:
                 from . import png
             except Exception as e:
-                logger.error(f"Error: {str(e)}.\n")
+                logger.debug(f"Warning: {str(e)}.\n")
                 import png
             try:
                 # we can only read png images as string content (not filename)
@@ -1354,7 +1354,7 @@ def set_payload_image(self, img):
                     palette=pngobj[3].get("palette", None),
                 )
             except Exception as e:
-                logger.error(f"Error: {str(e)}.\n")
+                logger.debug(f"Warning: {str(e)}.\n")
                 # enhanced images will fall into this case
                 data = report_utils.PIL_image_to_data(img)
                 self.width = data["width"]
@@ -1512,14 +1512,14 @@ def add_params(self, d: dict = None):
             self.params = json.dumps(tmp_params)
             return
         except Exception as e:
-            logger.error(f"Error: {str(e)}.\n")
+            logger.debug(f"Warning on add_params: {str(e)}.\n")
             return {}
 
     def get_params(self):
         try:
             return json.loads(self.params)
         except Exception as e:
-            logger.error(f"Error: {str(e)}.\n")
+            logger.debug(f"Warning on get_params: {str(e)}.\n")
             return {}
 
     def set_params(self, d: dict = None):

src/ansys/dynamicreporting/core/utils/report_remote_server.py

@@ -40,19 +40,6 @@
 logger = logging.getLogger("ansys.dynamicreporting.core")
 
 
-def disable_warn_logging(func):
-    # Decorator to suppress harmless warning messages
-    @functools.wraps(func)
-    def wrapper(*args, **kwargs):
-        logging.disable(logging.WARNING)
-        try:
-            return func(*args, **kwargs)
-        finally:
-            logging.disable(logging.NOTSET)
-
-    return wrapper
-
-
 def print_allowed():
     # Note: calling print() from a pythonw interpreter (e.g. template_editor launched
     # via the icon) can cause the interpreter to crash.  We will allow print, but only
@@ -249,7 +236,6 @@ def valid_database(self):
             return True
         return False
 
-    @disable_warn_logging
     def get_api_version(self):
         url = self.get_URL()
         if url is None:
@@ -269,7 +255,7 @@ def get_server_name(self):
             try:
                 self.validate()
             except Exception as e:
-                logger.warning(f"Error: {str(e)}")
+                logger.debug(f"Warning: {str(e)}")
                 pass
         if self.cur_servername is None:
             return self.get_URL()
@@ -295,7 +281,7 @@ def stop_server_allowed(self):
             if not result.ok:
                 return False
         except Exception as e:
-            logger.warning(f"Error: {str(e)}")
+            logger.debug(f"Warning: {str(e)}")
             return False
         return True
 
@@ -309,7 +295,7 @@ def stop_local_server(self):
             # note this request will fail as it does not return anything!!!
             self._http_session.get(url, auth=auth)
         except Exception as e:
-            logger.warning(f"Error: {str(e)}")
+            logger.debug(f"Warning: {str(e)}")
             pass
         self.set_URL(None)
         self.set_password(None)
@@ -332,7 +318,7 @@ def get_user_groups(self):
         try:
             return [str(obj_data.get("name")) for obj_data in r.json()]
         except Exception as e:
-            logger.warning(f"Error: {str(e)}")
+            logger.debug(f"Warning: {str(e)}")
             return []
 
     def get_object_guids(self, objtype=report_objects.Template, query=None):
@@ -360,7 +346,7 @@ def get_object_guids(self, objtype=report_objects.Template, query=None):
             else:
                 return [str(i) for i in r.json()["guid_list"]]
         except Exception as e:
-            logger.warning(f"Error: {str(e)}")
+            logger.debug(f"Warning: {str(e)}")
             return []
 
     def get_objects(self, objtype=report_objects.Template, query=None):
@@ -396,7 +382,7 @@ def get_objects(self, objtype=report_objects.Template, query=None):
                 ret.append(t)
             return ret
         except Exception as e:
-            logger.warning(f"Error: {str(e)}")
+            logger.debug(f"Warning: {str(e)}")
             return []
 
     def get_object_from_guid(self, guid, objtype=report_objects.TemplateREST):
@@ -422,7 +408,7 @@ def get_object_from_guid(self, guid, objtype=report_objects.TemplateREST):
             obj.from_json(r.json())
             return obj
         except Exception as e:
-            logger.warning(f"Error: {str(e)}")
+            logger.debug(f"Warning: {str(e)}")
             return None
 
     def _get_push_request_info(self, obj):
@@ -551,7 +537,7 @@ def put_objects(self, in_objects):
                 try:
                     r = self._http_session.put(url, auth=auth, files=files)
                 except Exception as e:
-                    logger.warning(f"Error: {str(e)}")
+                    logger.debug(f"Warning: {str(e)}")
                     r = self._http_session.Response()
                     r.status_code = requests.codes.client_closed_request
             ret = r.status_code
@@ -1236,7 +1222,7 @@ def create_new_local_database(
                 group.save()
                 os.makedirs(os.path.join(db_dir, "media"))
             except Exception as e:
-                logger.warning(f"Error: {str(e)}")
+                logger.debug(f"Warning: {str(e)}")
                 error = True
             if parent and has_qt:
                 QtWidgets.QApplication.restoreOverrideCursor()
@@ -1394,7 +1380,7 @@ def validate_local_db_version(db_dir, version_max=None, version_min=None):
             if number < version_min:
                 return False
     except Exception as e:
-        logger.warning(f"Error: {str(e)}")
+        logger.debug(f"Warning: {str(e)}")
         return False
     return True
 
@@ -1547,7 +1533,7 @@ def launch_local_database_server(
         local_lock = filelock.nexus_file_lock(api_lock_filename)
         local_lock.acquire()
     except Exception as e:
-        logger.warning(f"Error: {str(e)}")
+        logger.debug(f"Warning: {str(e)}")
         pass
     # We may need to do port scanning
     if port is None:  # nosec
@@ -1558,7 +1544,7 @@ def launch_local_database_server(
             scanning_lock = filelock.nexus_file_lock(lock_filename)
             scanning_lock.acquire()
         except Exception as e:
-            logger.warning(f"Error: {str(e)}")
+            logger.debug(f"Warning: {str(e)}")
             pass
         # Note: QWebEngineView cannot access http over 65535, so limit ports to 65534
         ports = report_utils.find_unused_ports(1)
@@ -1688,7 +1674,7 @@ def launch_local_database_server(
             )
         return False
     except Exception as e:
-        logger.warning(
+        logger.debug(
             f"This can throw an error at the validate step but still be able to start a new server: {str(e)}"
         )
         pass
@@ -1762,7 +1748,7 @@ def launch_local_database_server(
         # Note: this process only returns if the server is shutdown or there is an error
         monitor_process = subprocess.Popen(command, **params)  # nosec B78 B603
     except Exception as e:
-        logger.warning(f"Error: {str(e)}")
+        logger.debug(f"Warning: {str(e)}")
         if parent and has_qt:
             QtWidgets.QApplication.restoreOverrideCursor()
             msg = QtWidgets.QApplication.translate(
@@ -1824,7 +1810,7 @@ def launch_local_database_server(
             )
         except Exception as e:
             # we will try again
-            logger.warning(
+            logger.debug(
                 f"This can throw an error at the validate steps if it's just starting, but still work: {str(e)}"
             )
             pass