test(cff): Change skipif condition for flprj tests #927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafacanton
changed the title
rafacanton
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 85.12% 85.12%
=======================================
Files 52 52
Lines 5224 5224
=======================================
Hits 4447 4447
Misses 777 777 🚀 New features to boost your workflow:
|
rafacanton
changed the title
3 tasks
PProfizi
approved these changes
Nov 20, 2025
Contributor
PProfizi
left a comment
PProfizi
left a comment
There was a problem hiding this comment.
But if we tried to make a fix in pydpf-core we wouldn't have to skip those anymore, right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the investigation from #926, it is found out that the issues in flprj tests are due to gatebin incompatibilities. These are fixed in 26.1, so we need to keep them skipped in older servers.