Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: use sphinx-autoapi for API reference #1952

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

moe-ad
Copy link
Contributor

@moe-ad moe-ad commented Dec 4, 2024

This PR is related to ansys-internal/pyansys-planning#100. The migration of the API documentation migration is being handled here.

@jorgepiloto jorgepiloto changed the title Feat: first commit that results in sucessful documentation build doc: use sphinx-autoapi for API reference Dec 4, 2024
Copy link

codecov bot commented Dec 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.93%. Comparing base (ce858d8) to head (7b334a9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1952      +/-   ##
==========================================
- Coverage   88.11%   86.93%   -1.19%     
==========================================
  Files          83       83              
  Lines        9993     9993              
==========================================
- Hits         8805     8687     -118     
- Misses       1188     1306     +118     

@moe-ad
Copy link
Contributor Author

moe-ad commented Dec 4, 2024

@jorgepiloto, something I need to mention (already discussed with Revathy about this too).
If you try to build with sphinx 7.1.0 (which is the current default on this repo) while having autoapi enabled, the build fails. We narrowed it down to app.confdir being a str object in sphinx 7.1.0 and a path object in sphinx 8.1.3.

In ansys-sphinx-theme 1.2.2 (which is the current default on this repo), the autoapi extension treats app.confdir correctly (as a path object) but using sphinx 7.1.0 will result in an error because of the above reason.

In order words, we need sphinx 8.1.3 to be enforced moving forward.

@jorgepiloto
Copy link
Member

jorgepiloto commented Dec 4, 2024

Thanks for the research, @moe-ad. Then, let's focus on updating the rules for the moment. After that, we can update the examples to Jupytext. This should allow us to revisit the complete set of examples, making sure they run without random failures. Luckly, we can migrate to the latest Sphinx after that and merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants