Skip to content

Conversation

@SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Nov 18, 2025

Description

This PR is aiming at handling the first bullet point of #6896
Here we mitigate resource contention by avoiding to run the test for extensions / emit / solver solutions, unless there is a modification in the folder associated to each topic.
The tests are still run nightly and we'll have to consult them to know if something is going wrong with them.
Tests are still running when the PR is merge to ensure that we have code coverage fully evaluated on the repo. We could investigate if running the test nightly can be leveraged to still get a code coverage for the repo without running the test on main but that should be done in a second PR.

Pinging @jsalant22 @myoung301 @ramin4667 for visibility.

Issue linked

Associated to #6896

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.88%. Comparing base (f5adc6a) to head (a878bb9).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6897      +/-   ##
==========================================
+ Coverage   80.06%   80.88%   +0.82%     
==========================================
  Files         246      246              
  Lines       77866    78101     +235     
==========================================
+ Hits        62340    63173     +833     
+ Misses      15526    14928     -598     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review November 19, 2025 10:16
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner November 19, 2025 10:16
eblanco-ansys
eblanco-ansys previously approved these changes Nov 19, 2025
@SMoraisAnsys SMoraisAnsys self-assigned this Nov 19, 2025
@SMoraisAnsys
Copy link
Collaborator Author

Seems like our runner is impacted by nodejs/node#56645 so we cannot use astral-sh/setup-uv@v7. Changing to the latest v6 available.

Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

powerful!

@SMoraisAnsys SMoraisAnsys merged commit 4c6ee72 into main Nov 20, 2025
40 checks passed
@SMoraisAnsys SMoraisAnsys deleted the ci/rework-workflow-to-avoid-testing branch November 20, 2025 13:11
@eifinger
Copy link

Seems like our runner is impacted by nodejs/node#56645 so we cannot use astral-sh/setup-uv@v7. Changing to the latest v6 available.

I just released https://github.com/astral-sh/setup-uv/releases/tag/v7.1.4 which should fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants