Skip to content

Conversation

@SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Nov 18, 2025

Description

As title says.

Issue linked

Close #6887

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@SMoraisAnsys SMoraisAnsys changed the title TESTS: Avoid skipping and disable plot TEST: Avoid skipping and disable plot Nov 18, 2025
@github-actions github-actions bot added the testing Anything related to testing label Nov 18, 2025
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review November 18, 2025 09:03
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner November 18, 2025 09:03
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.06%. Comparing base (4c6ee72) to head (aaf94b8).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6889      +/-   ##
==========================================
+ Coverage   78.79%   81.06%   +2.27%     
==========================================
  Files         246      246              
  Lines       78101    78101              
==========================================
+ Hits        61536    63314    +1778     
+ Misses      16565    14787    -1778     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys
Copy link
Collaborator Author

This issue is akward because I was able to run the tests from within the CI with 4 workers... I'll see if updating the number of workers does change something. Note that there are still some matplotlib figures being open (and showing) as well as many figures created in some tests.

@github-actions github-actions bot added the maintenance Package and maintenance related label Nov 19, 2025
@SMoraisAnsys SMoraisAnsys self-assigned this Nov 19, 2025
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SMoraisAnsys
Copy link
Collaborator Author

@Samuelopez-ansys it seems that without multiple workers, the tests are passing. I'm trying with 2 workers to see how it behaves

@SMoraisAnsys
Copy link
Collaborator Author

It works with 2 workers, trying with a third one

@SMoraisAnsys SMoraisAnsys merged commit d1a69f7 into main Nov 20, 2025
40 checks passed
@SMoraisAnsys SMoraisAnsys deleted the tests/fix-visualization-tests branch November 20, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle testing issue with test_05_antenna_plot and test_06_farfield_exporter

4 participants