FIX: 6744-Update analysis.py #6770
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactor AvailableMethods class - add nominal_variation() method - deprecate get_independent_nominal_values() - update Analysis._export_touchstone() (fix #6744)
2 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6770 +/- ##
==========================================
- Coverage 83.51% 78.95% -4.56%
==========================================
Files 246 246
Lines 77864 77870 +6
==========================================
- Hits 65027 61486 -3541
- Misses 12837 16384 +3547 🚀 New features to boost your workflow:
|
- Also update unit tests.
Contributor
Author
|
@maxcapodi78 , @SMoraisAnsys : This is ready. |
| dict | ||
| Dictionary of independent nominal variations with values. | ||
| """ | ||
| return self.nominal_variation(dependent_params=False) |
Member
There was a problem hiding this comment.
Please add a warning here too, like:
warnings.warn(
"Usage of get_independent_nominal_values is deprecated. Use nominal_variation instead.",
DeprecationWarning,
stacklevel=2,
)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AvailableMethodsclassnominal_variation()methodget_independent_nominal_values()Analysis._export_touchstone()(fix Problem in exporting touchstone file with PyAEDT - Optimetrics - HFSS #6744)Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist