Skip to content

Conversation

@Samuelopez-ansys
Copy link
Member

@Samuelopez-ansys Samuelopez-ansys commented Oct 8, 2025

Description

Variable class refactoring. It should improve the usage of Object oriented programming, mainly in Circuit designs.

Issue linked

Close #6710
Close ##6906

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@Samuelopez-ansys Samuelopez-ansys requested a review from a team as a code owner October 8, 2025 10:09
@Samuelopez-ansys Samuelopez-ansys changed the title Fix/issue 6710 FIX: Improve Variable management in Circuit Oct 8, 2025
@github-actions github-actions bot added the bug Something isn't working label Oct 8, 2025
eblanco-ansys
eblanco-ansys previously approved these changes Oct 8, 2025
@codecov
Copy link

codecov bot commented Oct 8, 2025

Codecov Report

❌ Patch coverage is 87.27915% with 36 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.04%. Comparing base (27714c1) to head (ecbef2f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6742       +/-   ##
===========================================
+ Coverage   56.01%   81.04%   +25.02%     
===========================================
  Files         246      246               
  Lines       78112    78196       +84     
===========================================
+ Hits        43756    63373    +19617     
+ Misses      34356    14823    -19533     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@eblanco-ansys eblanco-ansys requested review from Copilot and removed request for Copilot November 5, 2025 09:50
# Conflicts:
#	tests/system/general/test_09_VariableManager.py
# Conflicts:
#	tests/system/general/test_01_Design.py
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very great job @Samuelopez-ansys I left some comments. Didn't check the tests changes yet, I'll do that later :)

return False
def update_var(self):
"""Push the current variable state to AEDT via variable manager."""
if not self._app:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably log an error here (could also be the case in other changes where if not self._app is used)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We allow the initialization of Variable class without AEDT, this is tested in test_variable.py

Not sure if we should log an error, because it means that the Variable object is updated, but the object can not update the variable in AEDT, because it is not connected... so instead of an error, it should be more a warning or info, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variable Defenition Error in Pyaedt

5 participants