-
Notifications
You must be signed in to change notification settings - Fork 204
FIX: Improve Variable management in Circuit #6742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6742 +/- ##
===========================================
+ Coverage 56.01% 81.04% +25.02%
===========================================
Files 246 246
Lines 78112 78196 +84
===========================================
+ Hits 43756 63373 +19617
+ Misses 34356 14823 -19533 🚀 New features to boost your workflow:
|
# Conflicts: # tests/system/general/test_09_VariableManager.py
# Conflicts: # tests/system/general/test_01_Design.py
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very great job @Samuelopez-ansys I left some comments. Didn't check the tests changes yet, I'll do that later :)
| return False | ||
| def update_var(self): | ||
| """Push the current variable state to AEDT via variable manager.""" | ||
| if not self._app: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably log an error here (could also be the case in other changes where if not self._app is used)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We allow the initialization of Variable class without AEDT, this is tested in test_variable.py
Not sure if we should log an error, because it means that the Variable object is updated, but the object can not update the variable in AEDT, because it is not connected... so instead of an error, it should be more a warning or info, what do you think?
# Conflicts: # tests/system/general/test_01_Design.py
Description
Variable class refactoring. It should improve the usage of Object oriented programming, mainly in Circuit designs.
Issue linked
Close #6710
Close ##6906
Checklist