-
Notifications
You must be signed in to change notification settings - Fork 152
FEAT: Add function to emit to list all component types #6210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
FEAT: Add function to emit to list all component types #6210
Conversation
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (77.77%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6210 +/- ##
==========================================
+ Coverage 84.06% 85.21% +1.14%
==========================================
Files 170 170
Lines 64179 64207 +28
==========================================
+ Hits 53955 54716 +761
+ Misses 10224 9491 -733 🚀 New features to boost your workflow:
|
@ramin4667 Can you add a unit test for this? Something as simple as grabbing the ComponentCatalog and verifying the number of components returned is the expected value I think would be sufficient. |
@ramin4667 This looks like it only shows the components that are in SysLib\EmitElements. Is it possible to also search the PersonalLib directory and show Emit components that the user has saved there? Preferably an optional argument to this (e.g. |
… of https://github.com/ansys/pyaedt into FEAT__Add_function_to_EMIT_to_list_all_component_types
@jsalant22 A unit test is added. |
@ramin4667 We can make this a separate user story. |
@jsalant22 A control named include_personal_lib to switch the library to PersonalLib if true. |
Description
This PR adds a search feature to find components for EMIT application .
Issue linked
Please mention the issue number or describe the problem this pull request addresses.
Checklist