Skip to content

CHORE: Update install targets and use dependency groups #6093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

SMoraisAnsys
Copy link
Collaborator

@SMoraisAnsys SMoraisAnsys commented Apr 29, 2025

Warning

Do not merge yet

Description

pip 25.1 is out and, on top implementing a first version for PEP 751: pylock.toml file, it implements PEP 735: Dependency groups. This avoids distributing our development dependencies as a target, thus avoiding confusing users.

On top of these changes, the optional dependencies have been refactored into mutliple subsets, leading to: dotnet, jupyter, graphics, analysis, io, all and examples. From now on, users installing from PyPI won't be able to install other targets than the one previously mentionned.. The doc and tests (unit/integration/system) are no longer available unless one clones the repository and install the associated dependencies with pip install --group tests

This PR should be merged once ansys/actions#794 is released.

Issue linked

Related to #5504

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate tests (unit, integration, system).
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved by the PR if any.
  • I have agreed with the Contributor License Agreement (CLA).

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@github-actions github-actions bot added the maintenance Package and maintenance related label Apr 29, 2025
@SMoraisAnsys
Copy link
Collaborator Author

Depends on ansys/actions#794

Copy link

codecov bot commented Apr 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.61%. Comparing base (271b03f) to head (59dd01c).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6093       +/-   ##
===========================================
- Coverage   85.26%   18.61%   -66.65%     
===========================================
  Files         170      170               
  Lines       64119    64119               
===========================================
- Hits        54668    11937    -42731     
- Misses       9451    52182    +42731     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SMoraisAnsys SMoraisAnsys self-assigned this Apr 30, 2025
MaxJPRey
MaxJPRey previously approved these changes Apr 30, 2025
@SMoraisAnsys SMoraisAnsys marked this pull request as draft May 5, 2025 07:04
@SMoraisAnsys SMoraisAnsys marked this pull request as ready for review May 14, 2025 09:26
@SMoraisAnsys SMoraisAnsys requested a review from a team as a code owner May 22, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants