Fix: disable 'price' on 'ModelElementalData' #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greschd
force-pushed
the
fix/remove_crashing_elemental_data_price
branch
from
478eccf to
8e93600
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
==========================================
- Coverage 94.99% 94.99% -0.01%
==========================================
Files 109 109
Lines 5695 5694 -1
Branches 322 322
==========================================
- Hits 5410 5409 -1
Misses 284 284
Partials 1 1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roosre
approved these changes
Nov 28, 2024
greschd
force-pushed
the
fix/remove_crashing_elemental_data_price
branch
from
f140e26 to
73cef38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comment out the
priceattribute on theModelElementalData, as a workaround to #717.Add a mass plot to the imported solid model example.
Closes #717.
Follow-up tasks tracked by #720.