Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs/imported solid model #697

Merged
merged 19 commits into from
Nov 27, 2024
Merged

Docs/imported solid model #697

merged 19 commits into from
Nov 27, 2024

Conversation

roosre
Copy link
Contributor

@roosre roosre commented Nov 22, 2024 •
edited
Loading

This PR adds an example for the definition of an Imported Solid Model (see #669 )

Additional changes:

  • add solid_mesh to the SolidElementSet to support visualization of this object type.
  • add format to the refresh method of the ImportedSolidModel

@roosre roosre added the documentation Improvements or additions to documentation label Nov 25, 2024
Base automatically changed from docs/solid_model to main November 25, 2024 12:48
@roosre roosre marked this pull request as ready for review November 25, 2024 13:21
@codecov Codecov
Copy link

codecov bot commented Nov 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.04%. Comparing base (c34ff53) to head (ac2a076).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #697   +/-   ##
=======================================
  Coverage   95.04%   95.04%           
=======================================
  Files         109      109           
  Lines        5710     5716    +6     
  Branches      323      324    +1     
=======================================
+ Hits         5427     5433    +6     
  Misses        282      282           
  Partials        1        1
Flag Coverage Δ
direct-launch 91.65% <100.00%> (+<0.01%) ⬆️
minimum-deps 93.25% <100.00%> (+<0.01%) ⬆️
python-3.10 94.31% <100.00%> (+<0.01%) ⬆️
python-3.11 94.24% <100.00%> (+<0.01%) ⬆️
python-3.12 94.43% <100.00%> (+<0.01%) ⬆️
server-2024R2 90.88% <71.42%> (-0.03%) ⬇️
server-2025R1 94.24% <100.00%> (+<0.01%) ⬆️
server-2025R2 94.24% <100.00%> (+<0.01%) ⬆️
server-latest 94.85% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

greschd
greschd approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@greschd greschd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice example!

@roosre roosre enabled auto-merge (squash) November 27, 2024 08:18
@roosre roosre merged commit 0ecbd07 into main Nov 27, 2024
31 checks passed
@roosre roosre deleted the docs/imported_solid_model branch November 27, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greschd greschd greschd approved these changes

@janvonrickenbach janvonrickenbach Awaiting requested review from janvonrickenbach

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roosre @greschd