feat: add 'serve' command to Makefile and make.bat for serving documentation #698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
|
@Revathyvenugopal162 CI jobs |
|
We are moving from these files to |
|
I dont mind tox or make file. But I think we should use one of those, since the purpose of them is to unify the repository commands. |
MaxJPRey
approved these changes
May 15, 2025
jorgepiloto
reviewed
May 16, 2025
Comment on lines
+37
to
+40
| # Serve docs | ||
| serve: | ||
| @echo "Serving docs..." | ||
| @cd ../ && stb serve $(DOCSDIR)/$(SOURCEDIR) |
There was a problem hiding this comment.
I this is is another argument in favor of just going with Tox. Tox manages paths the right way. Adding this forces us to run the Makefile only from the base directory.
germa89
commented
May 20, 2025
Revathyvenugopal162
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title. For better developer experience.
I am running on macOS, so I couldnt check the
batfile. TheMakefiledoes work though!