wip - cleanups, merging, splitting #216
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
force-pushed
the
intervals
branch
3 times, most recently
from
24988d6 to
ad1be6a
Compare
(_is_shipping_configured != is_shipping_configured)
the code paths for ... were not reachable, removed
SHIPPING_AUTH_CERTIFICATES
SHIPPING_AUTH_IDENTITY
SHIPPING_AUTH_S3_USERPASS
SHIPPING_AUTH_USERPASS
methods only used by PackageCRC moved there
abstract methods unused outside PackageCRC removed
subclasses now need to provide .ship
…last gather case now just the code needs to match
…er - remove none of these are ever a real value (last_gathering != load_last_gathered_entries ; save_last_gather != save_last_gathered_entries)
expose through METRICS_UTILITY_SHIP_AUTH should still remove these if unused after metrics-service CRC uploads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fixme: don't remove mutual-tls, split up, preserve gather_config 217 change)