AAP-35805 cleanup EE test #15765
Merged
AAP-35805 cleanup EE test #15765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismeyersfsu
force-pushed
the
AAP-35805-delete-ee
branch
2 times, most recently
from
f3bc9ee to
02dae46
Compare
AlanCoding
reviewed
Jan 23, 2025
chrismeyersfsu
force-pushed
the
AAP-35805-delete-ee
branch
3 times, most recently
from
d5eb75c to
242be9a
Compare
AlanCoding
reviewed
Jan 24, 2025
AlanCoding
reviewed
Jan 24, 2025
AlanCoding
approved these changes
Jan 24, 2025
chrismeyersfsu
force-pushed
the
AAP-35805-delete-ee
branch
2 times, most recently
from
7cd332b to
7e0321e
Compare
* Adds cleanup tests to the live test.
chrismeyersfsu
force-pushed
the
AAP-35805-delete-ee
branch
from
7e0321e to
2c9f94f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This test uses the new live tests to give confidence in our container cleanup code. We have function and unit test code for container cleanup, but it stops at the interface to runner. We verify the command line parameters that we construct, but our assumption in what the command-line params should look like was wrong. This test is not susceptible to that because it's an end to end test. This test is not perfect.
At the time of opening this draft PR the test is not exactly like production. To be like production we would need a control/hybrid + an execution node. We do not have that capability in our testing.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION