-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing MatchErrors due to hash collisions #4307
Fix missing MatchErrors due to hash collisions #4307
Conversation
1e33f8b
to
98558ff
Compare
98558ff
to
f3f0b38
Compare
Quality Gate passedIssues Measures |
I think the function ansible-lint/src/ansiblelint/errors.py Lines 144 to 156 in 7a78006
|
Setting the filename for match_error has been removed because this will be done on MatchError instance creation via the __post_init__ method.
f3f0b38
to
e5f7841
Compare
@marcandre-larochelle-bell I apologize for not getting around to your comment until now. I think it's fine to continue using the |
@cavcrosby No worries, I was mostly wondering, thanks for the reply! |
Fixes #4297.
This fix follows what was done here, #4202, for transitioning to passing a
lintable
argument forMatchError
object construction instead of afilename
argument. I also noticed a few places insrc/ansiblelint/utils.py
where this problem could be reproduced. Hence, I figured now would be a good time to address those spots as well.