Skip to content

Conversation

@x1101
Copy link
Contributor

@x1101 x1101 commented Oct 16, 2025

Converted docs builds to use nox -e make -- webdocs

Sample output for review from a run in my personal fork

@oraNod oraNod changed the title Convert buidls to use nox Convert builds to use nox Oct 16, 2025
@oraNod
Copy link
Contributor

oraNod commented Oct 17, 2025

@x1101 I don't have permissions to your repo's gha runs but that's OK. I'll push your changes to my own fork and try it there. At first glance your changes look good. They make the workflow simpler by moving things into nox so +1 for that.

@oraNod
Copy link
Contributor

oraNod commented Nov 3, 2025

@x1101 Hey, this looks pretty good to me but I think some of the commits don't look right. Could you rebase your branch against devel and update? I've tested this in my fork and think it's good to go. Thanks very much for this improvement!

@oraNod oraNod added doc builds Relates to building the documentation tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves. labels Nov 3, 2025
@oraNod oraNod changed the title Convert builds to use nox Consolidate doc build steps into the nox "make" session Nov 6, 2025
Copy link
Contributor

@oraNod oraNod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @x1101

@oraNod oraNod merged commit 3fba90e into ansible:devel Nov 6, 2025
12 checks passed
@x1101 x1101 deleted the f_1758 branch November 6, 2025 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc builds Relates to building the documentation tooling This PR affects tooling (CI, pr_labeler, noxfile, linters, etc.) but not the docs builds themselves.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants