Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-30403a Devtools: specify the id for registry login #1979

Merged
merged 1 commit into from
Sep 24, 2024
Merged

AAP-30403a Devtools: specify the id for registry login #1979

merged 1 commit into from
Sep 24, 2024

Conversation

ariordan-redhat
Copy link
Contributor

AAP-30403a Devtools: specify the ID for registry login
Affects /titles/develop-automation-content/

@ariordan-redhat ariordan-redhat added Needs backport to 2.4 Changes still need to be applied to the AAP 2.4 branch 2.4 Content applies to AAP 2.4 2.5 Content applies to AAP 2.5 Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels Sep 18, 2024
g-murray
g-murray approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@g-murray g-murray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one optional suggestion

downstream/modules/devtools/proc-devtools-install-container.adoc Show resolved Hide resolved
@g-murray g-murray merged commit d10e26d into ansible:main Sep 24, 2024
ariordan-redhat added a commit to ariordan-redhat/aap-docs that referenced this pull request Sep 24, 2024
@ariordan-redhat
AAP-30403a Devtools: registry login details (ansible#1979)
c601306
@ariordan-redhat ariordan-redhat deleted the aap-30403a branch September 24, 2024 10:25
ariordan-redhat added a commit to ariordan-redhat/aap-docs that referenced this pull request Sep 24, 2024
@ariordan-redhat
AAP-30403a Devtools: registry login details (ansible#1979)
1d646ca
This was referenced Sep 24, 2024
Merged
Merged
g-murray pushed a commit that referenced this pull request Sep 24, 2024
@ariordan-redhat
AAP-30403a Devtools: registry login details (#1979) (#2066)
c9c1bfe
g-murray pushed a commit that referenced this pull request Sep 24, 2024
@ariordan-redhat
AAP-30403a Devtools: registry login details (#1979) (#2065)
5f3e72c
@ariordan-redhat ariordan-redhat added Backported to 2.4 Changes have been applied to the AAP 2.4 branch Backported to 2.5 Changes have been applied to the AAP 2.5 branch and removed Needs backport to 2.4 Changes still need to be applied to the AAP 2.4 branch Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g-murray g-murray g-murray approved these changes

Assignees
No one assigned
Labels
2.4 Content applies to AAP 2.4 2.5 Content applies to AAP 2.5 Backported to 2.4 Changes have been applied to the AAP 2.4 branch Backported to 2.5 Changes have been applied to the AAP 2.5 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ariordan-redhat @g-murray