Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AAP-25510 Create safe plugin variable for Red Hat Insights EDA plugin and others #1784

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

AAP-25510 Create safe plugin variable for Red Hat Insights EDA plugin and others #1784

wants to merge 9 commits into from

Conversation

jself-sudoku
Copy link
Contributor

Added a new procedure:

  • downstream/titles/aap-installation-guide/platform/platform/proc-add-eda-safe-plugin-var.adoc

@jself-sudoku jself-sudoku added Draft Draft / work in progress: do not merge Needs backport to 2.4 Changes still need to be applied to the AAP 2.4 branch Ready for technical review Content is ready for technical reviews Not ready for peer review This PR is under construction and not ready for peer review 2.4 Content applies to AAP 2.4 2.5 Content applies to AAP 2.5 Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch labels Aug 25, 2024
jself-sudoku
jself-sudoku commented Aug 27, 2024
View reviewed changes
Copy link
Contributor Author

@jself-sudoku jself-sudoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamesmarshall24 - can you provide approval on this?

jamesmarshall24
jamesmarshall24 reviewed Aug 28, 2024
View reviewed changes
downstream/modules/platform/proc-add-eda-safe-plugin-var.adoc Outdated
. Add the `automationedacontroller_safe_plugins` variable along with a comma-separated list of plugins to enable for {EDAcontroller}. For example:
+
----
automationedacontroller_safe_plugins: “ansible.eda.webhook, ansible.eda.alertmanager”
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for "main" branch, so I don't think the right steps were used. There are two examples: one for 2.4 and one for 2.5. They're different between 2.4 and 2.5.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is going to be backported for 2.4 and then updated for 2.5. For that, I'll approve.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi James. I was going to backport this to 2.4 first, then update main, and backport to 2.5. After our discussion, I'll just update the 2.4 branch and ONLY backport the current content to 2.5.

@jself-sudoku jself-sudoku removed Needs backport to 2.4 Changes still need to be applied to the AAP 2.4 branch 2.4 Content applies to AAP 2.4 labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesmarshall24 jamesmarshall24 jamesmarshall24 approved these changes

Assignees
No one assigned
Labels
2.5 Content applies to AAP 2.5 Draft Draft / work in progress: do not merge Needs backport to 2.5 Changes still need to be applied to the AAP 2.5 branch Not ready for peer review This PR is under construction and not ready for peer review Ready for technical review Content is ready for technical reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jself-sudoku @jamesmarshall24