Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating load function to use cli_config #26

Open
wants to merge 6 commits into
base: devel
Choose a base branch
from

Conversation

justjais
Copy link
Member

@justjais justjais commented Feb 5, 2019

Updating the iosxr role Load function to use cli_config

Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
Signed-off-by: Sumit Jaiswal <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

Signed-off-by: Sumit Jaiswal <[email protected]>
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@NilashishC
Copy link
Member

@justjais Docs need update as well.

- name: Include configure task
include_tasks: includes/configure/configure.yaml
when: not ansible_check_mode and not iosxr_config_replace
- name: load configuration into device
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justjais replace functionality is missing from this task? You may refer to https://github.com/ansible-network/vyos/blob/devel/tasks/config_manager/load.yaml#L21

Copy link
Member

@NilashishC NilashishC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

includes/configure/configure.yaml is no longer required if cli_config is used for load task?

Copy link
Contributor

@samccann samccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs portion lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants