Skip to content

Conversation

@SLedunois
Copy link
Contributor

@SLedunois SLedunois commented Dec 16, 2025

Includes #313

Closes #315

Also see https://forum.keycloak.org/t/keycloak-26-4-7-ha/31202. As mentioned in this forum, the cache-ispn.xml file is included in the package, and you no longer need this file. We now need to configure the cache using the cache configuration properties.

Features:

  • Do not always include cache-ispn.xml file
  • You can now use a custom infinispan template
  • Embedded cache properties are no more ignored.
  • All Embedded cache properties are now replaced with a single keycloak_quarkus_cache_embedded_properties block variable

@SLedunois SLedunois force-pushed the main branch 2 times, most recently from b54a0fa to 81d2f40 Compare December 16, 2025 18:03
@SLedunois SLedunois changed the title v26.x compability v26.4.x compability Dec 17, 2025
@SLedunois
Copy link
Contributor Author

@RanabirChakraborty any news on the pull request ?

@RanabirChakraborty
Copy link
Member

@SLedunois I would like to see a new molecule test with keycloak_quarkus_cache_managed_infinispan_config where the keycloak_quarkus_version is a older one. So that we test both the cases for two different keycloak versions.

@SLedunois
Copy link
Contributor Author

@RanabirChakraborty added.

See the molecule test quarkus_ha_26.4_below. It uses keycloak_quarkus_version: 26.3.5. so the role implicitly sets keycloak_quarkus_cache_managed_infinispan_config to false, and the role copies the cache-ispn.xml file: https://github.com/ansible-middleware/keycloak/actions/runs/20810817395/job/59774377951?pr=317#step:5:560

@RanabirChakraborty
Copy link
Member

@SLedunois Thanks for the update, it's looking good now. But before i merge can you please make all the 17th dec commits under one commit, as all looks to be similar changes and count as one.

Also please add a NOTE in the main readme about the the usage of keycloak_quarkus_cache_managed_infinispan_config, when to use and why it has been done and a link to the official documentation, maybe after #### Infinispan configuration line ?

Copy link
Collaborator

@hwo-wd hwo-wd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be a bit late to the show, but still: thanks for your contribution.
Besides the things @RanabirChakraborty pointed out, could you please cherry-pick [9acfcade8aaa](https://github.com/world-direct/ansible-keycloak/commit/9acfcade8aaafb2e0a261e546ca3388d209ce8c8) and [43ec0473e4b4](https://github.com/world-direct/ansible-keycloak/commit/43ec0473e4b490f8864e77ce7e911b44af6871b4) such that this PR obsoletes #313 for good?

@SLedunois
Copy link
Contributor Author

@RanabirChakraborty Done. See the README file. I also squash the 3 commits.

@hwo-wd Done. You are now the author of this 2 commits 😊

For some mysterious reason, it seemed that the linter Github action no longer recognized the configuration, even though I hadn't touched it?

@RanabirChakraborty RanabirChakraborty added the major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to label Jan 9, 2026
@RanabirChakraborty
Copy link
Member

I have fixed the linting issue #319 please rebase the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

major_changes Major changes mean the user can CHOOSE to make a change when they update but do not have to

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No such JGroups stack 'JDBC_PING2'

3 participants