-
Notifications
You must be signed in to change notification settings - Fork 66
v26.4.x compability #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
v26.4.x compability #317
Conversation
b54a0fa to
81d2f40
Compare
|
@RanabirChakraborty any news on the pull request ? |
|
@SLedunois I would like to see a new molecule test with |
|
@RanabirChakraborty added. See the molecule test |
|
@SLedunois Thanks for the update, it's looking good now. But before i merge can you please make all the 17th dec commits under one commit, as all looks to be similar changes and count as one. Also please add a NOTE in the main readme about the the usage of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might be a bit late to the show, but still: thanks for your contribution.
Besides the things @RanabirChakraborty pointed out, could you please cherry-pick [9acfcade8aaa](https://github.com/world-direct/ansible-keycloak/commit/9acfcade8aaafb2e0a261e546ca3388d209ce8c8) and [43ec0473e4b4](https://github.com/world-direct/ansible-keycloak/commit/43ec0473e4b490f8864e77ce7e911b44af6871b4) such that this PR obsoletes #313 for good?
|
@RanabirChakraborty Done. See the README file. I also squash the 3 commits. @hwo-wd Done. You are now the author of this 2 commits 😊 For some mysterious reason, it seemed that the linter Github action no longer recognized the configuration, even though I hadn't touched it? |
|
I have fixed the linting issue #319 please rebase the PR. |
Includes #313
Closes #315
Also see https://forum.keycloak.org/t/keycloak-26-4-7-ha/31202. As mentioned in this forum, the
cache-ispn.xmlfile is included in the package, and you no longer need this file. We now need to configure the cache using the cache configuration properties.Features:
cache-ispn.xmlfilekeycloak_quarkus_cache_embedded_propertiesblock variable