make pyvmomi client inputs explicit #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
==========================================
- Coverage 60.84% 60.78% -0.07%
==========================================
Files 58 58
Lines 3731 3738 +7
Branches 597 597
==========================================
+ Hits 2270 2272 +2
- Misses 1306 1312 +6
+ Partials 155 154 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mikemorency
requested review from
shellymiron,
anna-savina,
prabinovRedhat,
bardielle and
OrrBG
as code owners
mariolenz
approved these changes
Mar 9, 2025
anna-savina
approved these changes
Mar 10, 2025
softwarefactory-project-zuul bot
pushed a commit
to ansible-collections/community.vmware
that referenced
this pull request
Mar 15, 2025
SUMMARY I think it might be helpful to de-couple the basic module logic from connecting to vSphere. This might be a first step to re-use code from vmware.vmware. That is, if they make plugins/module_utils/clients/_pyvmomi.py public. ISSUE TYPE Feature Pull Request COMPONENT NAME plugins/module_utils/clients/_vmware.py plugins/module_utils/vmware.py tests/unit/module_utils/test_vmware.py ADDITIONAL INFORMATION ansible-collections/vmware.vmware#133 ansible-collections/vmware.vmware#134 edit: vmdk_disk_path_split isn't used anywhere in this collection and therefor deprecated (#2311), so I think we can safely remove the unit tests for this: d741875 edit2: Since the collection requires ansible-core 2.17.0, which doesn't support Python 2.x at all, I guess we can drop (unit) tests for Python >= 2.7: 1ebf551 Reviewed-by: mikemorency Reviewed-by: Alexander Nikitin <[email protected]> Reviewed-by: Mario Lenz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Testing the recommendation from #133 and making client parameters explicit instead of relying on a dict
ISSUE TYPE
COMPONENT NAME
client/_pyvmomi