Feature/optimize search

[mikemorency]

SUMMARY

Implements a much faster search, using the propertyCollector class from pyvmomi. This was originally brought up in the discussion here: eddiehavila/community.vmware#1 (reply in thread)

ISSUE TYPE

• Feature Pull Request

COMPONENT NAME

pyvmomi base class and client

[codecov]

Codecov Report

Attention: Patch coverage is 97.20000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.87%. Comparing base (e23704a) to head (4a1e893).
Report is 16 commits behind head on main.

Files with missing lines	Patch %	Lines
plugins/module_utils/clients/_pyvmomi.py	73.68%	3 Missing and 2 partials ⚠️
plugins/module_utils/_module_pyvmomi_base.py	96.49%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #120      +/-   ##
==========================================
+ Coverage   61.65%   64.87%   +3.22%     
==========================================
  Files          60       60              
  Lines        3943     4151     +208     
  Branches      621      636      +15     
==========================================
+ Hits         2431     2693     +262     
+ Misses       1349     1296      -53     
+ Partials      163      162       -1     

Flag	Coverage Δ
units	64.87% <97.20%> (+3.22%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[mariolenz]

@mikemorency I'd really like to have a closer look at this and how it works in community.vmware. But I'll have to refactor some things there in order to test this.

Please beare with me some more days 🙏

[mariolenz]

I'm still trying to wrap my head around those changes. It's a little bit complicated, since I've lost track about a lot of the changes in this collection.

Anyway, while looking into the question how I can re-create your changes in community.vmware in order to test them I ran into another question. I think discussing this would be a little bit off-topic here, so I've created #133 to discuss this.

[mikemorency]

@mariolenz FYI Id like to merge this in the next few days

[mariolenz]

I'd like to test this approach in community.vmware, just to make sure that it works there also. I didn't find the time to do this yet, though.

I still want to do this. But if you want to merge and I didn't find the time to test until then, don't wait for me! As far as I can see, the code LGTM. I just thought it might be helpful to see how this works in community.vmware.

If in doubt, just merge and don't wait. When I find the time to tests this in the other collection, I'll let you know the result. No matter if this PR has been merged by then or not.