Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CoPP reserved names list #481

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

stalabi1
Copy link
Collaborator

@stalabi1 stalabi1 commented Nov 14, 2024

SUMMARY

A new CoPP reserved name, 'copp-system-cdp', has been added in SONiC so I updated the 'reserved_copp_names' list in the config file. I also alphabetized the list for better structure.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

sonic_copp

OUTPUT

regression-2024-11-13-16-16-30.html.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document

@stalabi1 stalabi1 added the bug Something isn't working label Nov 14, 2024
@stalabi1 stalabi1 added this to the v3.0.0 milestone Nov 14, 2024
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating the copp resource module to allow for the newly implemented "reserved" copp group name and for taking the initiative to order the list of reserved groups to make it easier for developers to search in the future.

Approved.

@kerry-meyer kerry-meyer merged commit 6074f82 into ansible-collections:main Nov 14, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants