Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ansible changes for Image Verification and GPG key installation #380

Merged
merged 18 commits into from
Nov 13, 2024
Merged

Ansible changes for Image Verification and GPG key installation #380

merged 18 commits into from
Nov 13, 2024

Conversation

aravindmani-1
Copy link
Contributor

@aravindmani-1 aravindmani-1 commented May 10, 2024 •
edited
Loading

SUMMARY

Added the changes required for Image verification and gpg key installation

GitHub Issues
GitHub Issue #
N/A
ISSUE TYPE
  • Feature Pull Request
COMPONENT NAME
  • sonic_image_management
OUTPUT

regression-2024-11-13-14-20-15.pdf

Checklist:
  • I have performed a self-review of my own code to ensure there are no formatting, linting, or security issues
  • I have verified that new and existing unit tests pass locally with my changes
  • I have not allowed coverage numbers to degenerate
  • I have maintained at least 90% code coverage
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have maintained backward compatibility or have provided any relevant "breaking_changes" descriptions in a "fragment" file in the "changelogs/fragments" directory of this repository.
  • I have provided a summary for this PR in valid "fragment" file format in the "changelogs/fragments" directory of this repository branch. Reference : Ansible Change Log Document
How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration

  • Test A
  • Test B

@aravindmani-1 aravindmani-1 changed the title Ansible changes for Image Verification Ansible changes for Image Verification and GPG key installation May 10, 2024
@aravindmani-1 aravindmani-1 marked this pull request as ready for review August 27, 2024 14:42
@kerry-meyer
Copy link
Collaborator

kerry-meyer commented Oct 25, 2024 •
edited
Loading

Hi Aravind,

Please fix the py3.11/py3.12 sanity errors flagged on this PR so we can proceed with review and merging of this PR.

                    Kerry

@kerry-meyer kerry-meyer added this to the v3.1.0 milestone Oct 25, 2024
@aravindmani-1
Copy link
Contributor Author

aravindmani-1 commented Oct 26, 2024 •
edited
Loading

Hi Aravind,

Please fix the py3.11/py3.12 sanity errors flagged on this PR so we can proceed with review and merging of this PR.

                    Kerry

Done. Updated the PR to latest sync.

ArunSaravananBalachandran
ArunSaravananBalachandran requested changes Nov 8, 2024
View reviewed changes
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
@aravindmani-1
Copy link
Contributor Author

New regression report:
regression-2024-11-12-15-46-56.pdf

Code coverage:
codecoverage test.txt

ArunSaravananBalachandran
ArunSaravananBalachandran requested changes Nov 13, 2024
View reviewed changes
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Outdated Show resolved Hide resolved
plugins/modules/sonic_image_management.py Show resolved Hide resolved
plugins/modules/sonic_image_management.py Show resolved Hide resolved
plugins/modules/sonic_image_management.py Show resolved Hide resolved
plugins/modules/sonic_image_management.py Show resolved Hide resolved
plugins/modules/sonic_image_management.py Show resolved Hide resolved
plugins/modules/sonic_image_management.py Show resolved Hide resolved
@aravindmani-1
Copy link
Contributor Author

Updated the new regression report in Description.

kerry-meyer
kerry-meyer approved these changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@kerry-meyer kerry-meyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed code and test changes and corresponding test results look good.

Thank you for providing the Ansible support for SONiC image verification and GPG key installation.

Approved.

@kerry-meyer kerry-meyer merged commit 14a07d4 into ansible-collections:main Nov 13, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArunSaravananBalachandran ArunSaravananBalachandran ArunSaravananBalachandran approved these changes

@kerry-meyer kerry-meyer kerry-meyer approved these changes

@stalabi1 stalabi1 Awaiting requested review from stalabi1 stalabi1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@aravindmani-1 @kerry-meyer @ArunSaravananBalachandran @stalabi1