Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added module vmware_guest_ft #1947

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

valentinJonev
Copy link
Contributor

SUMMARY

Added a module for managing fault tolerance

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

vmware_guest_ft

ADDITIONAL INFORMATION

Comment on lines +45 to +51
try:
from pyVim.task import WaitForTask
from pyVmomi import vim, vmodl, PyVmomi
# from tools import tasks
from ansible.module_utils._text import to_native
except ImportError as e:
raise e
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
try:
from pyVim.task import WaitForTask
from pyVmomi import vim, vmodl, PyVmomi
# from tools import tasks
from ansible.module_utils._text import to_native
except ImportError as e:
raise e
try:
from pyVim.task import WaitForTask
from pyVmomi import vim, vmodl, PyVmomi
# from tools import tasks
from ansible.module_utils._text import to_native
except ImportError:
pass

Please ignore the import error here. That's what the other other modules do, since PyVmomi already handles this. I think this will help to make the sanity tests happy.

Apropos making the sanity tests happy, you also have to add the GPLv3 license header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants